28
Github "dark mode" header
almost 7 years ago from Cihad Turhan, UI Developer and Designer
I'm seeing blackish header now on github. I'm not sure if it's A/B testing or else
27 comments
Mark Otto, almost 7 years ago Hey there! Not an A/B test—new dark header is here to stay. More coming soon! https://twitter.com/mdo/status/830138373230653440
Mehmet Yilmaz, almost 7 years ago
What's with the classes?
class="header header-dark user-logged-in true"Duncan Graham, almost 7 years ago
I've really enjoyed the mobile pattern of rounded corners around main content below a dark header. messed in inspector to see what it would look like on desktop
Gil Greenberg, almost 7 years ago hahah exactly this.
Jonathan Simcoe, almost 7 years ago
Seriously. Spot on GIF.
Roy Barber, almost 7 years ago
Would be interested to know the reason for the dark header, separation?
Joe Blau, almost 7 years ago I thought I somehow got logged into an enterprise account.
Trevor Curtis, almost 7 years ago
Black nav does feel very enterprisey.
Alec Lomas, almost 7 years ago
I don't like it. It could be just because it's new and I'm not used to it, but I think it's strange for just the header change to rollout before the rest of the design. I also think the links in the header are a bit too dark -- I think the header looks a little bit better with the alpha on those punched up to ~
0.85. I'm sure in like 3 days I won't even think about it anymore, though.Mark Otto, almost 7 years ago How's it feeling a few days later?
It still feels out of place, but I definitely have a much less reactionary response to it. I think it works best on pages where there's less blue (PRs/Issues compared to the Dashboard). And I've fully gone the other way on the link opacity,
0.75feels right. Excited to see what the other changes have in store!
jacob weber, almost 7 years ago
Saw it on Friday, and wasn't sure if I was logged in or out at first. But I am digging it.
Mark Otto, almost 7 years ago Thanks, Jacob! Holler with any additional feedback you might have <3.
Nick Tassone, almost 7 years ago
If the rest of the iterative changes are anything like this, bring em on. Looks/feels great.
Nate Dunn, almost 7 years ago
Honestly, it's fine. I think it feels a little "off-brand" and I am not sure what it accomplishes, but I will forget about it a week with how much I am on the site.
Lucian Marin, almost 7 years ago
Black top bars are bad for inertial scrolling.
Ean Moody, almost 7 years ago
When scrolling to the top the inertial bounce often reveals the white
<body>element which is distracting.This can sometimes be avoided by making the body dark, or by extending the header 50-100px above the top of the page (negative margin) but not on all browsers/OSs.
Some just render a white background no matter what as a shortcut and there's no fixing it.
Mark Otto, almost 7 years ago Definitely something that's on my mind. I've seen some folks resolve this with some hacking of padding and margin I think. Would like to dig into it more because I think it's a solvable problem :).
Krisztian Puska, almost 7 years ago
Nice. Even the incremental design rollout makes sense; a subtle refresh under the radar - keep' em coming.
If I had to nitpick... I'd wonder why the logo svg is 30px instead of 32. This way it gets a bit subpixeled on non-retina screens.
Mark Otto, almost 7 years ago Interestingly enough, we do 32px logged out and 30px logged in. I'll take a peek :).
Cool :) Props for taking the time to read the comments!
Mark Otto, almost 7 years ago Small heads up, shipped the size change and a few more things. Thanks again for the feedback!
alexey pushkarev, almost 7 years ago Let's see what is comming next. But github already has a very thorough and good dark restyling for stylish.
Login to Comment
You'll need to log in before you can leave a comment.
LoginRegister Today
New accounts can leave comments immediately, and gain full permissions after one week.
Register now